Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove kubevirt and set up redirects to community.kubevirt #1317

Merged
merged 4 commits into from
Jan 5, 2021
Merged

Remove kubevirt and set up redirects to community.kubevirt #1317

merged 4 commits into from
Jan 5, 2021

Conversation

dmsimard
Copy link
Contributor

@dmsimard dmsimard commented Nov 16, 2020 •
edited by felixfontein
Loading

kubevirt content has been moved to https://github.com/ansible-collections/community.kubevirt

Fixes #354.

@ansibullbot
Copy link
Collaborator

@dmsimard: Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information.

Here are the items we could not find in your description:

  • issue type

Please set the description of this pullrequest with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/PULL_REQUEST_TEMPLATE.md

click here for bot help

@ansibullbot
Copy link
Collaborator

cc @kubevirt @machacekondra @mmazur @pkliczewski
click here for bot help

@ansibullbot ansibullbot added affects_2.10 cloud docs_fragments docs_fragments plugin (shared docs) integration tests/integration inventory inventory plugin module module module_utils module_utils needs_info This issue requires further information. Please answer any outstanding questions needs_maintainer needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly needs_triage plugins plugin (any type) tests tests unit tests/unit community_review and removed needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly labels Nov 16, 2020
@dmsimard dmsimard mentioned this pull request Nov 16, 2020
Open
15 tasks
@felixfontein felixfontein mentioned this pull request Nov 19, 2020
Closed
@felixfontein
Copy link
Collaborator

Todo:

  • add changelog fragment
  • add redirects for doc fragments and module_utils
  • remove community.kubernetes dependency from galaxy.yml
  • remove community.kubernetes dependency from tests/requirements.yml
  • remove community.kubernetes dependency from tests/utils/shippable/shippable.sh

@felixfontein felixfontein added the breaking_change This PR contains a breaking change that MUST NOT be backported label Nov 24, 2020
@felixfontein felixfontein mentioned this pull request Dec 30, 2020
Closed
21 tasks
@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Dec 30, 2020
@dmsimard
Remove kubevirt and set up redirects to community.kubevirt
8618161 
This also removes the dependency on community.kubernetes which fixes
ansible-collections#354.
@dmsimard dmsimard marked this pull request as ready for review January 5, 2021 15:03
@ansibullbot ansibullbot removed the stale_ci CI is older than 7 days, rerun before merging label Jan 5, 2021
felixfontein
felixfontein reviewed Jan 5, 2021
View reviewed changes
changelogs/fragments/1317-kubevirt-migration-removal.yml Show resolved Hide resolved
changelogs/fragments/1317-kubevirt-migration-removal.yml Show resolved Hide resolved
galaxy.yml
dependencies:
community.kubernetes: '>=1.0.0'
# NOTE: No dependencies are expected to be added here
# dependencies:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SUCCESS

meta/runtime.yml Show resolved Hide resolved
David Moreau Simard and others added 3 commits January 5, 2021 10:16
@felixfontein felixfontein merged commit e53f153 into ansible-collections:main Jan 5, 2021
@felixfontein
Copy link
Collaborator

@dmsimard thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gundalow gundalow gundalow left review comments

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
breaking_change This PR contains a breaking change that MUST NOT be backported cloud community_review docs_fragments docs_fragments plugin (shared docs) has_issue integration tests/integration inventory inventory plugin module_utils module_utils module module needs_maintainer plugins plugin (any type) tests tests unit tests/unit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove collection runtime dependencies
4 participants
@dmsimard @ansibullbot @felixfontein @gundalow